linux-kernel - Re: [PATCH 2/2] dma/ep93xx_dma: prevent ep93xx_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Nov 2011 07:12:35 +0200
From:	Mika Westerberg <mika.westerberg@....fi>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"rmallon@...il.com" <rmallon@...il.com>,
	Rafal Prylowski <prylowski@...asoft.pl>
Subject: Re: [PATCH 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to
 access empty list

On Tue, Nov 22, 2011 at 02:26:52PM -0600, H Hartley Sweeten wrote:
> 
> I still don't like the BUG_ON here.  Is it even possible to get here with
> an empty list now that your catching it in the tasklet?

It's there just to make sure that we don't corrupt any memory if the list is
empty because of some other, yet unknown, bug.

> 
> But, ep93xx_dma_set_active() also has a BUG_ON test so...
> 
> Acked-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/