linux-kernel - Re: [PATCH] kconfig: Fix checking return value of 'fwrite'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111123055351.GB14454@mail.gmail.com>
Date:	Tue, 22 Nov 2011 22:53:51 -0700
From:	Jean Sacren <sakiwit@...il.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	Reinhard Tartler <Reinhard.Tartler@...ormatik.uni-erlangen.de>,
	Arnaud Lacombe <lacombar@...il.com>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	vamos-dev@...ts.informatik.uni-erlangen.de, amwang@...hat.com,
	sakiwit@...il.com
Subject: Re: [PATCH] kconfig: Fix checking return value of 'fwrite'

From: Michal Marek <mmarek@...e.cz>
Date: Sun, 20 Nov 2011 14:24:35 +0100
>
> On 7.10.2011 05:29, Arnaud Lacombe wrote:
> > Hi,
> > 
> > 2011/10/6 Reinhard Tartler <Reinhard.Tartler@...ormatik.uni-erlangen.de>:
> >> fwrite indicates '1' written member if a zero-length string is written.
> > you forgot the "Signed-off-by: " part :)
> 
> Reinhard, can I assume
> 
> Signed-off-by: Reinhard Tartler
> <Reinhard.Tartler@...ormatik.uni-erlangen.de>
> 
> ? The patch is otherwise correct.

I have two reasons to oppose this patch.

1. If 'len' value is zero, there is an issue already and it should be
taken care of _before_ calling fwrite().

2. xfwrite() doesn't fix anything except for the compiler warning. It
assumes this world is perfect and it's definitely not a place to take
care of the zero-length string.

-- 
Jean Sacren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/