| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Nov 2011 07:22:08 +0100 From: Corentin Chary <corentin.chary@...il.com> To: Greg KH <gregkh@...e.de> Cc: platform-driver-x86@...r.kernel.org, Matthew Garrett <mjg@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 05/15] samsung-laptop: ehance SABI support On Tue, Nov 22, 2011 at 11:18 PM, Greg KH <gregkh@...e.de> wrote: > On Tue, Nov 22, 2011 at 11:02:36PM +0100, Corentin Chary wrote: >> * SABI command are on 16 bits, not 8 > > Are you sure about that? I guess this would work, and we rely on the > bits being in the right order so everything works properly? Yep, I'm pretty sure this is the case, but I've not yet found a command using more than 8 bits. Anyway the 16 bit code works flawlessly here since we were already using "writew(command, ...);" since the beginning. Regarding the bits order, the driver depends on X86, so I don't see this as a real issue. >> * SABI can read/write up to 11 byte of data > > It can? That's how it seems to work, but I didn't see any command using more that 24 bits yet. >> * There is not real difference between "get" and "set" >> commands, so refactorise the code of both functions > > Ah, nice, I always wanted to do that. > >> Signed-off-by: Corentin Chary <corentincj@...aif.net> > > Acked-by: Greg Kroah-Hartman <gregkh@...e.de> > > -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists