linux-kernel - [PATCH] percpu: add comment to per_cpu_ptr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111123084543.GA2923@darkstar.nay.redhat.com>
Date:	Wed, 23 Nov 2011 16:45:43 +0800
From:	Dave Young <dyoung@...hat.com>
To:	tj@...nel.org, xiyou.wangcong@...il.com, kexec@...ts.infradead.org,
	tim@...ecast.com, linux-kernel@...r.kernel.org
Subject: [PATCH] percpu: add comment to per_cpu_ptr_to_phys

add comments about current per_cpu_ptr_to_phys implementation
to explain why the logic is more complicated than necessary.

Signed-off-by: Dave Young <dyoung@...hat.com>
---
 mm/percpu.c |   13 +++++++++++++
 1 file changed, 13 insertions(+)

--- linux-2.6.orig/mm/percpu.c	2011-11-22 10:18:46.000000000 +0800
+++ linux-2.6/mm/percpu.c	2011-11-23 16:27:01.667562973 +0800
@@ -988,6 +988,19 @@ phys_addr_t per_cpu_ptr_to_phys(void *ad
 	unsigned int cpu;
 
 	/*
+	 * percpu allocator has special setup for the first chunk,
+	 * which currently supports either embedding in linear address space
+	 * or vmalloc mapping, and, from the second one, the backing
+	 * allocator (currently either vm or km) provides translation.
+	 *
+	 * The addr can be tranlated simply without checking if it falls
+	 * into the first chunk. But the current code reflects better
+	 * how percpu allocator actually works, and the verification can
+	 * discover both bugs in percpu allocator itself and
+	 * per_cpu_ptr_to_phys() callers. So we keep current code.
+	 */
+
+	/*
 	 * The following test on first_start/end isn't strictly
 	 * necessary but will speed up lookups of addresses which
 	 * aren't in the first chunk.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/