linux-kernel - Re: [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322045375.1516.249.camel@vkoul-udesk3>
Date:	Wed, 23 Nov 2011 16:19:35 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Viresh Kumar <viresh.kumar@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Armando VISCONTI <armando.visconti@...com>,
	Shiraz HASHIM <shiraz.hashim@...com>,
	Vipin KUMAR <vipin.kumar@...com>,
	Rajeev KUMAR <rajeev-dlh.kumar@...com>,
	Deepak SIKRI <deepak.sikri@...com>,
	Vipul Kumar SAMAR <vipulkumar.samar@...com>,
	Amit VIRDI <Amit.VIRDI@...com>,
	Pratyush ANAND <pratyush.anand@...com>,
	Bhupesh SHARMA <bhupesh.sharma@...com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	Bhavna YADAV <bhavna.yadav@...com>,
	Vincenzo FRASCINO <Vincenzo.FRASCINO@...com>,
	Mirko GARDI <mirko.gardi@...com>
Subject: Re: [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan_cfg
 register on resume

On Tue, 2011-11-22 at 11:50 +0530, Viresh Kumar wrote:
> On 11/22/2011 9:43 AM, Vinod Koul wrote:
> > On Thu, 2011-11-17 at 16:01 +0530, Viresh Kumar wrote:
> >> > In S2R all DMA registers are reset by hardware and thus they are required to be
> > When are they reset, whenever you leave channel idle or once you come
> > back from suspend?
> 
> Whenever we do S2R, many power islands are switched off and so DMAC controller looses
> all its power. On resume, all registers are in their reset state.
then why not perform save and restore in your suspend and restore
callbacks. That way you don't pay penalty of doing that in every alloc
as you seem to be doing now?

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/