linux-kernel - Re: [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322047933.1516.266.camel@vkoul-udesk3>
Date:	Wed, 23 Nov 2011 17:02:13 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Viresh Kumar <viresh.kumar@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Armando VISCONTI <armando.visconti@...com>,
	Shiraz HASHIM <shiraz.hashim@...com>,
	Vipin KUMAR <vipin.kumar@...com>,
	Rajeev KUMAR <rajeev-dlh.kumar@...com>,
	Deepak SIKRI <deepak.sikri@...com>,
	Vipul Kumar SAMAR <vipulkumar.samar@...com>,
	Amit VIRDI <Amit.VIRDI@...com>,
	Pratyush ANAND <pratyush.anand@...com>,
	Bhupesh SHARMA <bhupesh.sharma@...com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	Bhavna YADAV <bhavna.yadav@...com>,
	Vincenzo FRASCINO <Vincenzo.FRASCINO@...com>,
	Mirko GARDI <mirko.gardi@...com>
Subject: Re: [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan_cfg
 register on resume

On Wed, 2011-11-23 at 16:41 +0530, Viresh Kumar wrote:
> On 11/23/2011 4:19 PM, Vinod Koul wrote:
> > then why not perform save and restore in your suspend and restore
> > callbacks. That way you don't pay penalty of doing that in every alloc
> > as you seem to be doing now?
> 
> Not actually. I am not saving anything to be restored after suspend.
> There are few things (configuring CFG regs and enabling interrupts),
> which are done earlier on alloc_channels. As this will not be called after
> resume, so we need to set them again.
> 
> What i have done is, removed all this stuff from alloc channels and moved it
> to dwc_dostart(). Here, i am checking if channel is already programmed or not.
> If not (Can happen only in two cases: On resume and other on fresh channel alloc),
> i configure them. So there is no save/restore actually done.
> 

okay, why were you writing to registers in alloc in the first place :)
it should have been in the dostart.

Okay now i get it, looks fine to me, I will apply it


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/