linux-kernel - Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHR064hKKXfnnwj9mc+ZKwqXw2yyu0sOokdo8KqpMnM5Ju_5Dw@mail.gmail.com>
Date:	Wed, 23 Nov 2011 17:51:35 +0100
From:	Corentin Chary <corentin.chary@...il.com>
To:	David Herrmann <dh.herrmann@...glemail.com>
Cc:	Greg KH <gregkh@...e.de>, platform-driver-x86@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

On Wed, Nov 23, 2011 at 5:41 PM, David Herrmann
<dh.herrmann@...glemail.com> wrote:
> On Wed, Nov 23, 2011 at 7:35 AM, Corentin Chary
> <corentin.chary@...il.com> wrote:
>> On Tue, Nov 22, 2011 at 11:23 PM, Greg KH <gregkh@...e.de> wrote:
>>> On Tue, Nov 22, 2011 at 11:02:42PM +0100, Corentin Chary wrote:
>>>> Signed-off-by: Corentin Chary <corentincj@...aif.net>
>>>
>>> What happens on boxes that don't have this type of hardware?  Will the
>>> LED device still show up, yet it will not work?
>>>
>>> You should be able to trigger this off of the model type somehow, much
>>> like the video backlight should work.
>>
>> kbd_backlight_enable(samsung) will be called, it will fire a {0x78,
>> 0xaabb} command on machines using swsmi and this command will fail if
>> the feature is not available. I did some test, and unknown commands
>> seems to fail gracefully, and that makes sabi_command() (and callers)
>> return -EINVAL).
>>
>> It think {0x78, 0x80} is also here to tell if the backlight is
>> available or not, but I can't test it, since it always returns 1 here.
>
> I do not have a keyboard backlight and hence always get an error
> message on boot up. It would be great to suppress this error message
> as this is not really an error (for me):
> samsung_laptop: SABI command 0x0078 failed with completion flag 0xaa
>
>> So yeah, if someone could test that on a swsmi laptop without keyboard
>> backlight, that would be great.

Yep I've seen that, working on it.



-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/