linux-kernel - Re: [PATCH 08/15] samsung-laptop: add battery life extender support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANq1E4T+JeQbB0zTtpAo3Qyz3Yj3H0EwccvM44nJjCQmDkJPOQ@mail.gmail.com>
Date:	Wed, 23 Nov 2011 21:14:55 +0100
From:	David Herrmann <dh.herrmann@...glemail.com>
To:	Corentin Chary <corentin.chary@...il.com>
Cc:	platform-driver-x86@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Randy Dunlap <rdunlap@...otime.net>,
	Matthew Garrett <mjg@...hat.com>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/15] samsung-laptop: add battery life extender support

On Wed, Nov 23, 2011 at 7:11 PM, Corentin Chary
<corentin.chary@...il.com> wrote:
> On Wed, Nov 23, 2011 at 6:10 PM, David Herrmann
> <dh.herrmann@...glemail.com> wrote:
>> On Wed, Nov 23, 2011 at 5:54 PM, Corentin Chary
>> <corentin.chary@...il.com> wrote:
>>>> My BIOS provides this option, too. However, this driver does not
>>>> detect it on my machine. During initialization I get:
>>>> samsung_laptop: SABI command 0x0078 failed with completion flag 0xaa
>>>>
>>>> Maybe you can help debugging this. If there is something I can test
>>>> via debugfs, just tell me.
>>>
>>> Could you try to load the module with debug=1, type these commands
>>>
>>> $ cd /sys/kernel/debug/
>>> $ echo 0x65 > command
>>> $ for i in d0 d1 d2 d3; echo 0 > $i; done
>>> $ echo 0x80 > d0
>>> $ cat call
>>
>> Would be great if you could add a short comment, what it does, next time ;)
>
> Hum sorry, basically it calls the SABI command 0x65 with 0x80 as the
> first argument byte.
>
>> SABI 0x0065 {0x00000080, 0x00000000, 0x0000, 0x00}
>> SABI {0x00000000, 0x00000000, 0x0000, 0x00}
>>
>> dmesg:
>> [ 4988.985360] This computer supports SABI==f518a
>> [ 4988.985374] SABI header:
>> [ 4988.985384]  SMI Port Number = 0x00b2
>> [ 4988.985393]  SMI Interface Function = 0xc0
>> [ 4988.985402]  SMI enable memory buffer = 0xc1
>> [ 4988.985412]  SMI restore memory buffer = 0xc2
>> [ 4988.985421]  SABI data offset = 0x0f00
>> [ 4988.985429]  SABI data segment = 0xdf01
>> [ 4988.985438]  SABI pointer = 0x000dff10
>> [ 4988.985448] samsung_laptop: Backlight controlled by ACPI video driver
>> [ 4988.985478] samsung_laptop: SABI 0x0065 {0x00000080, 0x00000000,
>> 0x0000, 0x00}
>> [ 4988.991847] samsung_laptop: SABI {0x00000000, 0x00000000, 0x0000, 0x00}
>> [ 4988.991886] samsung_laptop: SABI 0x0067 {0x00000080, 0x00000000,
>> 0x0000, 0x00}
>> [ 4988.993298] samsung_laptop: SABI {0x00000000, 0x00000000, 0x0000, 0x00}
>> [ 4988.993332] samsung_laptop: SABI 0x0069
>> [ 4988.994856] samsung_laptop: SABI {0x00010201, 0x00000000, 0x0001, 0x02}
>> [ 4988.998294] samsung_laptop: SABI 0x0069
>> [ 4988.999780] samsung_laptop: SABI {0x00010201, 0x00000000, 0x0001, 0x02}
>> [ 4988.999801] samsung_laptop: SABI 0x0069
>> [ 4989.001247] samsung_laptop: SABI {0x00010201, 0x00000000, 0x0001, 0x02}
>> [ 4989.001269] samsung_laptop: SABI 0x006a {0x00010001, 0x00000000,
>> 0x0001, 0x02}
>> [ 4989.002847] samsung_laptop: SABI {0x00010201, 0x00000000, 0x0001, 0x02}
>> [ 4989.007453] samsung_laptop: SABI 0x0069
>> [ 4989.008914] samsung_laptop: SABI {0x00010201, 0x00000000, 0x0001, 0x02}
>> [ 4989.008936] samsung_laptop: SABI 0x0069
>> [ 4989.010409] samsung_laptop: SABI {0x00010201, 0x00000000, 0x0001, 0x02}
>> [ 4989.010430] samsung_laptop: SABI 0x006a {0x00010001, 0x00000000,
>> 0x0001, 0x02}
>> [ 4989.011998] samsung_laptop: SABI {0x00010201, 0x00000000, 0x0001, 0x02}
>> [ 4989.012589] samsung_laptop: SABI 0x0078 {0x0000aabb, 0x00000000,
>> 0x0000, 0x00}
>> [ 4989.013996] samsung_laptop: SABI command 0x0078 failed with
>> completion flag 0xaa
>
> Something is very strange here, the 0x65 didn't fail so you should
> really have /sys/devices/platform/samsung/battery_life_extender .
> Are you really sure it's not there ?

Argh. I did see the usb_charge but somehow missed the
battery_life_extender. I am sorry. Works both on my machine and sets
the BIOS flags correctly.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/