linux-kernel - Re: [RFC] cdc-acm: Fix potential deadlock (lockdep warning)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111123215909.5bec72bf@bob.linux.org.uk>
Date:	Wed, 23 Nov 2011 21:59:09 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Havard Skinnemoen <hskinnemoen@...gle.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jiri Slaby <jirislaby@...il.com>
Subject: Re: [RFC] cdc-acm: Fix potential deadlock (lockdep warning)

On Wed, 23 Nov 2011 13:03:27 -0800
Havard Skinnemoen <hskinnemoen@...gle.com> wrote:

> On Wed, Nov 23, 2011 at 11:44 AM, Alan Cox <alan@...ux.intel.com>
> wrote:
> > Any data owned by the USB part needs to be handled by the USB
> > driver. In the case of usb-serial it keeps its own krefs for that
> > because the lifetime of the port/USB serial data is not the same as
> > the lifetime of the tty itself.
> 
> Yes, exactly. But since tty_port already has a kref, why not use that?
> It doesn't have any other use currently.

Indeed
 
> Hmm, a quick grep tells me tty_port_get() and tty_port_put() are
> completely unused. What was the intention behind them?

To provide a way to use the kref nicely.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/