linux-kernel - Re: [PATCH] usb: musb: PM: fix context save/restore in suspend/resume path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111124092751.GG3352@legolas.emea.dhcp.ti.com>
Date:	Thu, 24 Nov 2011 11:27:52 +0200
From:	Felipe Balbi <balbi@...com>
To:	Kevin Hilman <khilman@...com>
Cc:	Felipe Balbi <balbi@...com>, linux-omap@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"open list:MUSB MULTIPOINT H..." <linux-usb@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: musb: PM: fix context save/restore in
 suspend/resume path

Hi,

On Tue, Nov 22, 2011 at 05:18:24PM -0800, Kevin Hilman wrote:
> Currently the driver tries to save context in the suspend path, but
> will cause an abort if the device is already runtime suspended.  This
> happens, for example, if MUSB loaded/compiled-in, in host mode, but no
> USB devices are attached.  MUSB will be runtime suspended, but then
> attempting a system suspend will crash due to the context save
> being attempted while the device is disabled.
> 
> On OMAP, as of v3.1, the driver's ->runtime_suspend() callback will be
> called late in the suspend path (by the PM domain layer) if the driver
> is not already runtime suspended, ensuring a full shutdown.
> 
> Therefore, the context save is not needed in the ->suspend() method
> since it will be called in the ->runtime_suspend() method anyways
> (similarily for resume.)
> 
> NOTE: this leaves the suspend/resume methods basically empty (with
>       some FIXMEs and comments, but I'll leave it to the maintainers
>       to decide whether to remove them.
> 
> Signed-off-by: Kevin Hilman <khilman@...com>

applied, thanks.

I've added Cc: stable@...r.kernel.org so that this goes to v3.1 too.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)