linux-kernel - Re: [PATCH v1] USB: OTG should be linked before Host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111124094024.GL3352@legolas.emea.dhcp.ti.com>
Date:	Thu, 24 Nov 2011 11:40:26 +0200
From:	Felipe Balbi <balbi@...com>
To:	Neil Zhang <zhangwm@...vell.com>
Cc:	Peter Chen <hzpeterchen@...il.com>, Greg KH <gregkh@...e.de>,
	"balbi@...com" <balbi@...com>,
	Haojian Zhuang <hzhuang1@...vell.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] USB: OTG should be linked before Host

On Wed, Nov 23, 2011 at 11:19:44PM -0800, Neil Zhang wrote:
> > -----Original Message-----
> > From: Peter Chen [mailto:hzpeterchen@...il.com]
> > Sent: 2011年11月24日 14:06
> > To: Greg KH
> > Cc: Neil Zhang; balbi@...com; Haojian Zhuang; linux-usb@...r.kernel.org
> > Subject: Re: [PATCH v1] USB: OTG should be linked before Host
> > 
> > On Thu, Nov 24, 2011 at 12:17 AM, Greg KH <gregkh@...e.de> wrote:
> > > On Wed, Nov 23, 2011 at 06:38:48PM +0800, Neil Zhang wrote:
> > >> For OTG controller, the host driver will call function
> > >> otg_get_transceiver to get the otg transceiver, so we need to init
> > the
> > >> OTG driver before HOST.
> > >
> > I agree with it, at freescale i.mx platform, we also need to init otg
> > first, then the host
> > if otg function is enabled.
> > 
> > > How do you handle this if these drivers are built as modules?
> > We require the user load module by order, and write it at UserGuide.
> > 
> > I find at older kernel version, like 2.6.38, the otg was built firstly
> > at usb module.
> 
> Actually, it was changed by the following patch.
> 
> commit 4661ffc91befc8c5ee080720120da1d53851060a
> Author: Felipe Balbi <balbi@...com>
> Date:   Thu Apr 7 10:59:34 2011 +0300
> 
>     usb: don't enter usb subdirectories directly
> 
>     Instead, make we enter usb/ directory on all
>     needed cases and enter the subdirectories from
>     drivers/usb/Makefile.
> 
>     Signed-off-by: Felipe Balbi <balbi@...com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> Hi Balbi,
> Do you have any concern to change it?

not from my side, we need the transceivers before the DRD controllers
can probe.

FWIW:

Acked-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)