linux-kernel - Re: [PATCH 1/3] usb: udc: Fix gadget driver's speed check in various UDC drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111124094651.GR3352@legolas.emea.dhcp.ti.com>
Date:	Thu, 24 Nov 2011 11:46:52 +0200
From:	Felipe Balbi <balbi@...com>
To:	Michal Nazarewicz <mpn@...gle.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Felipe Balbi <balbi@...com>,
	Thomas Dahlmann <dahlmann.thomas@...or.de>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Anatolij Gustschin <agust@...x.de>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Ben Dooks <ben@...tec.co.uk>, Heiko Stubner <heiko@...ech.de>,
	Thomas Abraham <thomas.ab@...sung.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/3] usb: udc: Fix gadget driver's speed check in various
 UDC drivers

On Sat, Nov 19, 2011 at 06:26:25PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@...a86.com>
> 
> Several UDC drivers had a gadget driver's speed sanity check of the
> form of:
> 
> 	driver->speed != USB_SPEED_HIGH
> 
> or:
> 
> 	driver->speed != USB_SPEED_HIGH && driver->speed != USB_SPEED_FULL
> 
> As more and more gadget drivers support USB SuperSpeed, driver->speed
> may be set to USB_SPEED_SUPER and UDC driver should handle such gadget
> correctly.  The above checks however fail to recognise USB_SPEED_SUPER
> as a valid speed.
> 
> This commit changes the two checks to:
> 
> 	driver->speed < USB_SPEED_HIGH
> 
> or:
> 
> 	driver->speed < USB_SPEED_FULL
> 
> respectively.
> 
> Signed-off-by: Michal Nazarewicz <mina86@...a86.com>
> Reported-by: Alan Stern <stern@...land.harvard.edu>

applied, thanks

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)