linux-kernel - Re: [PATCH] [TRIVIAL] [RESEND] leds: Kconfig: Fix typo 'D2NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111124102949.GA18490@kw.sim.vm.gnt>
Date:	Thu, 24 Nov 2011 11:29:49 +0100
From:	Simon Guinot <simon@...uanux.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Jiri Kosina <trivial@...nel.org>, Simon Guinot <sguinot@...ie.com>,
	Nicolas Pitre <nico@...xnic.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [TRIVIAL] [RESEND] leds: Kconfig: Fix typo 'D2NET_V2'

Hi Paul,

On Thu, Nov 24, 2011 at 11:08:37AM +0100, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> 0) This corrects an obvious typo. That typo was added in commit
> 84712e9aa4 ("[ARM] Kirkwood: add LaCie d2 Network v2 support") which
> added support for 'MACH_D2NET_V2'.
> 
> 1) I sent this yesterday to trivial@...nel.org only. However, this
> allows people using a "LaCie d2 Network v2 NAS Board" to enable "LED
> support for Network Space v2 GPIO LEDs" and thus lets them run code that
> they can't run now. So, to be really safe, this time I've also CC'd the

They can run this code because more likely the same binary kernel
supports all the Kirkwood machines, including MACH_NETSPACE_V2, etc...

And that's why I missed this typo :)

> people involved in that commit to (perhaps test this and) ACK or NAK
> this.

Acked-by: Simon Guinot <sguinot@...ie.com>

Thanks for the patch.

Simon

> 
>  drivers/leds/Kconfig |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index ff203a4..1b75a56 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -347,7 +347,8 @@ config LEDS_MC13783
>  config LEDS_NS2
>  	tristate "LED support for Network Space v2 GPIO LEDs"
>  	depends on LEDS_CLASS
> -	depends on MACH_NETSPACE_V2 || MACH_INETSPACE_V2 || MACH_NETSPACE_MAX_V2 || D2NET_V2
> +	depends on MACH_NETSPACE_V2 || MACH_INETSPACE_V2 || \
> +		   MACH_NETSPACE_MAX_V2 || MACH_D2NET_V2
>  	default y
>  	help
>  	  This option enable support for the dual-GPIO LED found on the
> -- 
> 1.7.7.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)