linux-kernel - Re: [PATCH 2/8] firmware: Sigma: Skip header during CRC generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201111241222.00189.vapier@gentoo.org>
Date:	Thu, 24 Nov 2011 12:21:57 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	"Lars-Peter Clausen" <lars@...afoo.de>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	drivers@...log.com, stable@...nel.org
Subject: Re: [PATCH 2/8] firmware: Sigma: Skip header during CRC generation

On Thursday 24 November 2011 07:48:21 Lars-Peter Clausen wrote:
> The firmware header is not part of the CRC, so skip it. Otherwise the
> firmware will be rejected due to non-matching CRCs.

that's because you didn't compare to the right value ;).  include the CRC -> 
compare to 0.  omit the CRC -> compare to the CRC value.

including the CRC and doing a compare to 0 would probably make for slightly 
smaller code ...
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)