linux-kernel - Re: [PATCH] comedi: integer overflow in do_insnlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <97189E06-26D8-4CF9-B325-06403FB1C42C@gmail.com>
Date:	Thu, 24 Nov 2011 14:07:49 -0500
From:	Xi Wang <xi.wang@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Ian Abbott <abbotti@....co.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Mori Hess <fmhess@...rs.sourceforge.net>,
	"security@...nel.org" <security@...nel.org>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Ian Abbott <ian.abbott@....co.uk>,
	Franky Lin <frankyl@...adcom.com>,
	Greg Dietsche <Gregory.Dietsche@....edu>,
	Mark Pearson <markpearson_de@...oo.de>
Subject: Re: [PATCH] comedi: integer overflow in do_insnlist_ioctl()

Using kcalloc looks good to me.  Do you want to redo the patch in that way?

- xi

On Nov 23, 2011, at 4:51 PM, Dan Carpenter wrote:
> 
> I think the reason why I didn't do that in my original patch is that
> kcalloc() has a memset(..., 0, ...) in it so it's a slow down.  But
> this isn't performance critical code so that would work.
> 
> regards,
> dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/