linux-kernel - strace based on perf [Re: libperf interface stability]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ECE98CD.7060902@gmail.com>
Date:	Thu, 24 Nov 2011 12:19:41 -0700
From:	David Ahern <dsahern@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
CC:	Robert Richter <robert.richter@....com>, mingo@...hat.com,
	eranian@...gle.com, linux-kernel@...r.kernel.org,
	fweisbec@...il.com, efault@....de, peterz@...radead.org,
	Arun Sharma <asharma@...com>
Subject: strace based on perf [Re: libperf interface stability]

On 11/24/2011 11:10 AM, Arnaldo Carvalho de Melo wrote:
> I'm working right now on another effort that hopefully will end up
> easing the development of new tools, in-perf and outside, current goal
> is to have a strace like tool using using code carved out from tools.

Interesting. I was thinking about this as well -- and Arun too I believe.

> 
> I have a branch that I explicitely mark as unstable where I'm putting
> what I have at:
> 
> https://github.com/acmel/linux/commits/tmp.perf/trace4
> 
> I hope to have it in a form that is reasonable to move it to 'perf/core'
> and then ask Ingo to merge it in the next merge window.
> 
> This is how the 'strace' is looking like, removing the error handling to
> simplify:
> 
> static const char *strace__tracepoints[] = {
> 	"raw_syscalls:sys_enter",
> 	"raw_syscalls:sys_exit",
> };

That answers the quandry about having a zillion event fd's for all the
syscalls.

> 
> static int strace(struct perf_record_opts *opts, const char *argv[])
> {
> 	struct perf_evlist *evlist = perf_evlist__new(NULL, NULL);
> 
> 	err = perf_evlist__create_maps(evlist, opts->target_pid,
> 				       opts->target_tid, opts->cpu_list);
> 
> 	err = perf_evlist__add_tracepoints_array(evlist, strace__tracepoints);
> 
> 	err = perf_evlist__prepare_workload(evlist, opts, argv);
> 
> 	perf_evlist__config_attrs(evlist, opts);
> 
> 	err = perf_evlist__open(evlist, opts->group);
> 
> 	err = perf_evlist__mmap(evlist, opts->mmap_pages, false);
> 
> 	perf_evlist__start_workload(evlist);
> 
> 	/*
> 	 * WIP: use perf_evlist__read, etc and then feed a
> 	 * perf_event_ops operations sorted events like is done in
> 	 * perf_session__process_events. Top is like that but currently
> 	 * doesn't use perf_session__process_events, we need to make it
> 	 * use something refactored out from perf_session that does the
> 	 * ordering of samples perf_session does, etc.
> 	 */
> 
> 	perf_evlist__munmap(evlist);
> 
> 	perf_evlist__delete(evlist);
> }

Have you given thought to how you will compute the time spent in the
syscalls?

I've been playing around with ideas on my end -- like storing 'last seen
times' in struct thread {} and struct perf_evsel{}. For evsel it is CPU
based, so something like:

struct perf_evsel {
...
    u64 *last_time; /* time this event was last seen */
    u32 max_cpu;    /* highest cpu slot allocated */
};

And then methods to save/retrieve the time:

void perf_evsel__save_time(struct perf_evsel *evsel,
                                  u64 timestamp, u32 cpu)
{
	if ((cpu > evsel->max_cpu) || (evsel->last_time == NULL)) {
		unsigned int i;

		if (evsel->last_time)
			evsel->last_time = realloc(evsel->last_time,
				(cpu+1) * sizeof(u64));
		else
			evsel->last_time = malloc((cpu+1) * sizeof(u64));

		if (!evsel->last_time)
		    return;

		i = evsel->max_cpu ? evsel->max_cpu + 1 : 0;
		for (; i <= cpu; ++i)
			evsel->last_time[i] = (u64) 0;

		evsel->max_cpu = cpu;
	}

	evsel->last_time[cpu] = timestamp;
}

u64 perf_evsel__get_time(struct perf_evsel *evsel, u32 cpu)
{
	if (!evsel->last_time)
	    return 0;

	if ((cpu > evsel->max_cpu) || (evsel->last_time == NULL))
	    return 0;

	return evsel->last_time[cpu];
}

Saving the times allows to you compute delta-times -- between events and
per tasks.

For raw syscalls that gets harder -- now you need to save times per cpu
per syscall number. Or maybe save event histories within the thread struct.

I'll find some time to try out your trace branch over the long holiday
weekend here.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/