linux-kernel - Re: [PATCH 2/2] dma/ep93xx_dma: prevent ep93xx_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111124054731.GB2621@mwesterb-mobl.ger.corp.intel.com>
Date:	Thu, 24 Nov 2011 07:47:31 +0200
From:	Mika Westerberg <mika.westerberg@....fi>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"rmallon@...il.com" <rmallon@...il.com>,
	Rafal Prylowski <prylowski@...asoft.pl>
Subject: Re: [PATCH 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to
 access empty list

On Wed, Nov 23, 2011 at 04:30:34PM +0530, Vinod Koul wrote:
> 
> will you still hit the problem if you do a proper check in tasklet for 
> a) if list is empty
> b) if _get_active_desc() returns valid desc
> and the _get_active_desc() returns NULL on not finding active desc

No, with the above the problem goes away.

> The point is by adding a flag you are avoiding the condition hence it is
> working for you whereas on other approach you exit gracefully without
> crashing in all the cases (including potentially uncovered ones)

Ok I see.

I'll prepare a new version where ep93xx_dma_get_active() returns NULL in case
of empty active list, and handle it properly in callers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/