linux-kernel - Re: Floating point usage inside kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ECFCAD5.5040606@grupopie.com>
Date:	Fri, 25 Nov 2011 17:05:25 +0000
From:	Paulo Marques <pmarques@...popie.com>
To:	Nuno Santos <nsantos@...gma.com>
CC:	Jiri Slaby <jirislaby@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: Floating point usage inside kernel

Nuno Santos wrote:
> Hi Jiri,

Hi, Nuno

> [...]
> But now that I have opened this question here I should ask... is it safe?

No!

> [...]
> And the input data is the following:
> 
> src[0] = [0,6300]; src[1] = [0,6300]; src[2] = 1.0;
> zone->Matrix (double[3][3])
> 
> u: 492.188 v: 615.234 sx: 683.158 sy: 5790.13
> 
> u: 5807.81 v: 615.234 sx: 5944.9 sy: 5900.58
> 
> u: 5807.81 v: 5684.77 sx: 6027.46 sy: 560.337
> 
> u: 492.188 v: 5684.77 sx: 751.198 sy: 476.455
> 
> 
> and tex is output (double[3])
[...]

Given the range of numbers you're working with, you can probably get
away with just a 16.16 fixed point representation. The operations go
like this:

convert a double to a fixed point number just do (but not on the kernel):

  fixed = (s32)(double * 65536.0);

convert an integer to fixed:

  fixed = integer << 16;

multiplication:

  result = (s32)(((s64) fixed_a * fixed_b) >> 16);

addition:

  result = fixed_a + fixed_b;

etc...

Unless you have overflow or need more than 16 bits of fractional
precision, you'll have no problem with this approach.

I hope this helps,

-- 
Paulo Marques - www.grupopie.com

"All generalizations are false."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/