linux-kernel - Re: [PATCH 6/8] ASoC: SigmaDSP: Provide diagnostic error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201111251502.37100.vapier@gentoo.org>
Date:	Fri, 25 Nov 2011 15:02:34 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	"Lars-Peter Clausen" <lars@...afoo.de>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	drivers@...log.com
Subject: Re: [PATCH 6/8] ASoC: SigmaDSP: Provide diagnostic error messages

On Friday 25 November 2011 03:59:21 Lars-Peter Clausen wrote:
> On 11/24/2011 06:32 PM, Mike Frysinger wrote:
> > On Thursday 24 November 2011 07:48:25 Lars-Peter Clausen wrote:
> >> +	if (crc != le32_to_cpu(ssfw_head->crc)) {
> >> +		dev_err(&client->dev, "Failed to load firmware: Wrong crc 
checksum:"
> >> \ +			" expected %x got %x.\n",
> > 
> > it's my understanding that string constants should not be split
> 
> I think it is fine here. You probably wouldn't grep for %x anyway.

no, but you would copy and paste a string like:
	"Failed to load firmware: Wrong crc checksum: expected"
and then not find a match

i think it's best to follow the style anyways ...

also, no need for the period at the end of the msg.  that's useless noise and 
can be annoying to copying & pasting numbers.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)