linux-kernel - Re: [PATCH] staging: iio: fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111125093331.GP2203@ZenIV.linux.org.uk>
Date:	Fri, 25 Nov 2011 09:33:31 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Arnd Hannemann <arnd@...dnet.de>
Cc:	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: fix compile error

On Thu, Nov 24, 2011 at 10:25:50PM +0100, Arnd Hannemann wrote:
> Commit b46413367961c2e8bd827e067a231be982aaeee2 introduced the following compile error:
> 
>   CC      drivers/staging/iio/industrialio-core.o
> linux-2.6/drivers/staging/iio/industrialio-core.c: In function 'iio_event_getfd':
> linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: error: 'ev_int' undeclared (first use in this function)
> linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: note: each undeclared identifier is reported only once for each function it appears in
> 
> This patch fixes that.

Arrgh...  My fault, sorry.  Might be worth using the same local variable
for setting the bit as well...

Acked-by: Al Viro <viro@...iv.linux.org.uk>

> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 2656409..a5b4a1f 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -243,6 +243,7 @@ static const struct file_operations iio_event_chrdev_fileops = {
>  static int iio_event_getfd(struct iio_dev *indio_dev)
>  {
>  	int fd;
> +	struct iio_event_interface *ev_int = indio_dev->event_interface;
>  
>  	if (indio_dev->event_interface == NULL)
>  		return -ENODEV;
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/