linux-kernel - Re: [Regression, 3.2-rc1] ath9k broken on AR928X (was: Re: Linux 3.2-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-VmonZYrEJS7UkqdSTnMQ5waDjPgSpVDPqiHz2=Uksso5tHw@mail.gmail.com>
Date:	Sun, 27 Nov 2011 05:54:56 +0800
From:	Adrian Chadd <adrian@...ebsd.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Senthil Balasubramanian <senthilb@....qualcomm.com>,
	"John W. Linville" <linville@...driver.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Wireless <linux-wireless@...r.kernel.org>,
	"Luis R. Rodriguez" <mcgrof@....qualcomm.com>
Subject: Re: [Regression, 3.2-rc1] ath9k broken on AR928X (was: Re: Linux
 3.2-rc3 - just in time for Thanksgiving)

On 27 November 2011 05:32, Rafael J. Wysocki <rjw@...k.pl> wrote:
>> Tomorrow I'll try to identify the offending commits.
>
> Well, it took more time than I had hoped. :-(
>
> Bisection turns up:
>
> commit 2577c6e8f2320f1d2f09be122efef5b9118efee4
> Author: Senthil Balasubramanian <senthilb@....qualcomm.com>
> Date:   Tue Sep 13 22:38:18 2011 +0530
>
>    ath9k_hw: Add support for AR946/8x chipsets.
>
>    This patch adds support for AR946/8x chipets.

Oh god. That's going to be fun to figure out :)

> which I think is wrong for at lest two reasons.  Not that I understand
> what it actually does to the driver, but first, it does much more than the
> changelog says and, second, it is practically impossible to revert
> because of the number of commits on top depending on it.  Quite frankly,
> it is about to make it to my list of examples of how things should _not_ be
> done in the kernel.
>
> The commit immediately preceding it doesn't show any symptoms of failure, so
> I'm quite convinced this one really introduced the problem for me.
>
> The chip in the affected box is (according to "lspci -v"):

Can you please find out what the actual PCI device id is? That way I
can help you (hopefully) isolate which bits of that change would cause
your regression.

That commit almost exclusively touches the AR93xx chipset support, so
I can't (easily) see how this would break support for the AR928x NICs.

Adrian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/