linux-kernel - Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <aefc95$2cas5k@orsmga001.jf.intel.com>
Date:	Sat, 26 Nov 2011 16:53:23 +0000
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	Keith Packard <keithp@...thp.com>, akpm@...ux-foundation.org,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick <rakib.mullick@...il.com> wrote:
> Yes, no real problem with current code. I was just thinking from code
> cleanup's pov. Is BUG_ON really needed in i915_add_request() ?

No, just documentation as a reminder that the request should be
preallocated, ideally so that we can fail gracefully without touching
hardware and leaving it in an inconsistent state wrt to our bookkeeping.
(This is more apparent in the overlay code which could hang the
chip/driver if we hit a malloc error too late.)

The BUG_ON has certainly outlived its usefulness.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/