linux-kernel - Re: iwlagn is getting very shaky

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANUX_P1aAz-4TpgSzQ2G=RkJOxXCAVQBja3GNsj_HpMNmqxeUw@mail.gmail.com>
Date:	Sun, 27 Nov 2011 11:43:16 +0200
From:	Emmanuel Grumbach <egrumbach@...il.com>
To:	Norbert Preining <preining@...ic.at>
Cc:	"Guy, Wey-Yi" <wey-yi.w.guy@...el.com>,
	David Rientjes <rientjes@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ipw3945-devel@...ts.sourceforge.net" 
	<ipw3945-devel@...ts.sourceforge.net>,
	"ilw@...ux.intel.com" <ilw@...ux.intel.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Dave Jones <davej@...hat.com>
Subject: Re: iwlagn is getting very shaky

Hi again

Can you please try the attached patch ?
I would like to know if it helps.

Thanks !

On Sun, Nov 27, 2011 at 08:38, Emmanuel Grumbach <egrumbach@...il.com> wrote:
>> Yeah, that was my impression too, but still, I wanted to mention it.
>>
>>> I am already on week-end here and will look at it more carefully
>>> later. First impression is that things are messy here. I guess we are
>>> getting in a bad failure path that wasn't checked...
>>
>> No problem, I can cope with it.
>>
>
> you can always disable 11n: modprobe 11n_disable=1.
>
> Well... Something is really weird here:
> mac80211 requests from us to:
> * start agg
> * stop agg
> * agg operational
>
> this is not a legal sequence
>
> BTW - I am under this impression that mac80211 hasn't been compiled
> with HT debug flag. Can you please set this compilation flag ?
>
> I also would like you to add this line in iwlagn_mac_ampdu_action:
>
>
> static int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
>                                   struct ieee80211_vif *vif,
>                                   enum ieee80211_ampdu_mlme_action action,
>                                   struct ieee80211_sta *sta, u16 tid, u16 *ssn,
>                                   u8 buf_size)
> {
>        struct iwl_priv *priv = hw->priv;
>        int ret = -EINVAL;
>        struct iwl_station_priv *sta_priv = (void *) sta->drv_priv;
>
>        IWL_DEBUG_HT(priv, "A-MPDU action on addr %pM tid %d\n",
>                     sta->addr, tid);
>
> dump_stack();   <<<<========================================= new line
>
>        if (!(priv->cfg->sku & EEPROM_SKU_CAP_11N_ENABLE))
>                return -EACCES;
>
>
>
> This will give an insight at why is mac80211 calling the driver and
> better point me to the bug.
>
>
> Thanks !
>

View attachment "addba_timer_fix.patch" of type "text/x-patch" (563 bytes)