linux-kernel - Re: [PATCH] regulator: Avoid potential NULL dereference in reg_fixed_voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111127113529.GG2896@opensource.wolfsonmicro.com>
Date:	Sun, 27 Nov 2011 11:35:29 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Rajendra Nayak <rnayak@...com>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: Avoid potential NULL dereference in
 reg_fixed_voltage_probe()

On Sun, Nov 27, 2011 at 10:13:50AM +0800, Axel Lin wrote:

> -	if (pdev->dev.of_node)
> +	if (pdev->dev.of_node) {
>  		config = of_get_fixed_voltage_config(&pdev->dev);
> +		if (!config)
> +			return -ENOMEM;
> +	}

Looking at this I'm thinking it's better to just drop the check for
of_node entirely and just let of_get_fixed_voltage_config() fail to find
what it needs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/