linux-kernel - Re: [PATCH] ath9k: Revert change that broke AR928X on Acer Ferrari One

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ED1D7BE.7040401@openwrt.org>
Date:	Sun, 27 Nov 2011 13:25:02 +0700
From:	Felix Fietkau <nbd@...nwrt.org>
To:	Adrian Chadd <adrian@...ebsd.org>
CC:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Senthil Balasubramanian <senthilb@....qualcomm.com>,
	"Luis R. Rodriguez" <mcgrof@....qualcomm.com>,
	"John W. Linville" <linville@...driver.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Wireless <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] ath9k: Revert change that broke AR928X on Acer Ferrari
 One

On 2011-11-27 8:16 AM, Adrian Chadd wrote:
> Hm, considering the origina patch did this:
> 
>         /* Clear Bit 14 of AR_WA after putting chip into Full Sleep mode. */
> -       if (AR_SREV_9300_20_OR_LATER(ah))
> -               REG_WRITE(ah, AR_WA,
> -                         ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
> +       if (!AR_SREV_9480(ah))
> +               REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
> 
> .. something tells me that perhaps the correct statement is:
> 
> if (AR_SREV_9300_20_OR_LATER(ah) && !AR_SREV_9480(ah))
>     REG_WRITE() ...
> 
I checked again, the !AR_SREV_9480(ah) was intentionally removed in a
later change, so using AR_SREV_9300_20_OR_LATER(ah) is correct.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/