linux-kernel - [PATCH] [SCSI] sd: Lower printk level for drive cache information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111128163053.GA24618@zod.bos.redhat.com>
Date:	Mon, 28 Nov 2011 11:31:55 -0500
From:	Josh Boyer <jwboyer@...hat.com>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] [SCSI] sd: Lower printk level for drive cache information

Numerous devices don't present cache data, particularly USB sticks.  The
devices operate correctly despite this, so lower the printk severity to
KERN_NOTICE.

Signed-off-by: Josh Boyer <jwboyer@...hat.com>

---

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index fa3a591..7cf9ec5 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2119,7 +2119,7 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer)
 		}

 		if (modepage == 0x3F) {
-			sd_printk(KERN_ERR, sdkp, "No Caching mode page "
+			sd_printk(KERN_NOTICE, sdkp, "No Caching mode page "
 				  "present\n");
 			goto defaults;
 		} else if ((buffer[offset] & 0x3f) != modepage) {
@@ -2164,7 +2164,7 @@ bad_sense:
 		sd_printk(KERN_ERR, sdkp, "Asking for cache data failed\n");

 defaults:
-	sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n");
+	sd_printk(KERN_NOTICE, sdkp, "Assuming drive cache: write through\n");
 	sdkp->WCE = 0;
 	sdkp->RCD = 0;
 	sdkp->DPOFUA = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/