linux-kernel - Re: [PATCH 3/7] ASoC: AD193X: Make enum items const char * const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ED3DA92.6050704@metafoo.de>
Date:	Mon, 28 Nov 2011 20:01:38 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, drivers@...log.com,
	device-drivers-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 3/7] ASoC: AD193X: Make enum items const char * const

On 11/28/2011 07:53 PM, Mark Brown wrote:
> On Mon, Nov 28, 2011 at 05:28:08PM +0100, Lars-Peter Clausen wrote:
> 
>> -static const char *ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
>> +static const char * const ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
> 
> Ideally this would be converted to a switch and the driver would
> automatically select the rate based on the current sample rate.

Ideally yes, but I'm not sure if this couldn't break some existing setup if it
expects to find that control.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/