linux-kernel - Re: [PATCH] w1: add fast search for single slave bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111128202414.GA11903@ioremap.net>
Date:	Mon, 28 Nov 2011 23:24:14 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Hubert Feurstein <h.feurstein@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] w1: add fast search for single slave bus

Hi

On Mon, Nov 28, 2011 at 09:06:47PM +0100, Hubert Feurstein (h.feurstein@...il.com) wrote:
> This enables a much more efficient way of device searching. It uses the
> 1-wire read-rom operation which allows the direct reading of the slave
> address. BUT this works only with exactly one slave on the bus.

Although idea may sound resonable, kernel is shipped with only one
compiled option, and it is quite uncommon to recompile them.
So this option will unlikely to be enabled. I would recommend to add
either a module parameter to forbid multiple slave devices and use fast
search, or use fast search when only one device exists and switch to
common search when it fails (if it is possible to detect that there are
multiple devices on the bus using fast search)

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/