linux-kernel - Re: [PATCH v3 1/2] sunrpc: make rpc_wait_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111128203901.GG18864@google.com>
Date:	Mon, 28 Nov 2011 12:39:01 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Jeff Layton <jlayton@...hat.com>
Cc:	rjw@...k.pl, linux-kernel@...r.kernel.org,
	linux-nfs@...r.kernel.org, linux-pm@...r.kernel.org,
	john@...va.com, trond.myklebust@...app.com,
	marek.belisko@...il.com, awilliam@...hat.com
Subject: Re: [PATCH v3 1/2] sunrpc: make rpc_wait_bit_killable handle
 freeze events

Hello,

On Mon, Nov 28, 2011 at 03:01:27PM -0500, Jeff Layton wrote:
> +#define freezable_schedule()						\
> +({									\
> +	freezer_do_not_count();						\
> +	if (!try_to_freeze())						\
> +		schedule();						\
> +	freezer_count();						\
> +})

I don't think you need try_to_freeze() there when you apply this on
top of pm-freezer branch.  Per-task freezing flag is gone and freezing
condition is completely transient from the POV of each task and the
freezer also doesn't care at all whether a task enters freezer or
becomes unfreezable.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/