linux-kernel - Re: [PATCH 01/62] highmem: mark k[un]map_atomic() with two arguments as deprecated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Nov 2011 13:07:00 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Cesar Eduardo Barros <cesarb@...arb.net>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Nick Bowler <nbowler@...iptictech.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Christoph Lameter <cl@...ux.com>, Tejun Heo <tj@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 01/62] highmem: mark k[un]map_atomic() with two arguments
 as deprecated

于 2011年11月27日 20:34, Cesar Eduardo Barros 写道:
>
> This will break the misuse detection of kunmap_atomic (see commit 597781f3e51f48ef8e67be772196d9e9673752c4).
>
> kunmap_atomic() _must_ be a macro, so the __same_type can see the type the caller used. If you use an inline function, all it will see is a void *, even if the caller confused it with kunmap() and passed a struct page *.
>

Hmm, I think you are right, I will switch it back to a macro.

Thanks for review!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/