linux-kernel - Re: [PATCH 10/11] wireless: Remove redundant spi driver bus initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322464807.6502.11.camel@cumari>
Date:	Mon, 28 Nov 2011 09:20:07 +0200
From:	Luciano Coelho <coelho@...com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	linux-kernel@...r.kernel.org, Dan Williams <dcbw@...hat.com>,
	"John W. Linville" <linville@...driver.com>,
	Christian Lamparter <chunkeey@...glemail.com>,
	libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 10/11] wireless: Remove redundant spi driver bus
 initialization

On Thu, 2011-11-24 at 16:29 +0100, Lars-Peter Clausen wrote: 
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
> 
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> 	.driver = {
> -		.bus = &spi_bus_type,
> 	},
> };
> // </smpl>
> 
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Dan Williams <dcbw@...hat.com>
> Cc: "John W. Linville" <linville@...driver.com>
> Cc: Christian Lamparter <chunkeey@...glemail.com>
> Cc: Luciano Coelho <coelho@...com>
> Cc: libertas-dev@...ts.infradead.org
> Cc: linux-wireless@...r.kernel.org
> ---

[...]

> diff --git a/drivers/net/wireless/wl1251/spi.c b/drivers/net/wireless/wl1251/spi.c
> index eaa5f95..6248c35 100644
> --- a/drivers/net/wireless/wl1251/spi.c
> +++ b/drivers/net/wireless/wl1251/spi.c
> @@ -319,7 +319,6 @@ static int __devexit wl1251_spi_remove(struct spi_device *spi)
>  static struct spi_driver wl1251_spi_driver = {
>  	.driver = {
>  		.name		= DRIVER_NAME,
> -		.bus		= &spi_bus_type,
>  		.owner		= THIS_MODULE,
>  	},
>  
> diff --git a/drivers/net/wireless/wl12xx/spi.c b/drivers/net/wireless/wl12xx/spi.c
> index 0f97186..12421a6 100644
> --- a/drivers/net/wireless/wl12xx/spi.c
> +++ b/drivers/net/wireless/wl12xx/spi.c
> @@ -462,7 +462,6 @@ static int __devexit wl1271_remove(struct spi_device *spi)
>  static struct spi_driver wl1271_spi_driver = {
>  	.driver = {
>  		.name		= "wl1271_spi",
> -		.bus		= &spi_bus_type,
>  		.owner		= THIS_MODULE,
>  	},

For the wl12xx and wl1251 parts:

Acked-by: Luciano Coelho <coelho@...com>


-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/