linux-kernel - Re: linux-next: build warning after merge of the l2-mtd tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878vmz8d9e.fsf@free.fr>
Date:	Tue, 29 Nov 2011 10:54:37 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Artem Bityutskiy <dedekind1@...il.com>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: linux-next: build warning after merge of the l2-mtd tree

Stephen Rothwell <sfr@...b.auug.org.au> writes:
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/mtd/devices/docg3.c: In function 'doc_write_page_ecc_init':
> drivers/mtd/devices/docg3.c:577:6: warning: suggest parentheses around operand
> of '!' or change '|' to '||' or '!' to '~' [-Wparentheses]

Hi Stephen,

My fault, I've been too lazy with that commit for too long, and code like
writel(!reg1 | reg2, adr) is error prone. Artem did point out the warning
already, so that's on me.

I'll mend the fix in a V2 to a cleanup patch already submitted to linux-mtd.

Cheers.

-- 
Robert

PS: there will be another warning about an unused function
doc_get_erase_count(). This one will be fixed a bit later I'm afraid.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/