linux-kernel - Re: [PATCH 12/25] perf symbols: Add nr_events to symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 29 Nov 2011 09:52:05 -0200
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 12/25] perf symbols: Add nr_events to symbol_conf

Em Mon, Nov 28, 2011 at 09:44:38PM -0700, David Ahern escreveu:
> On 11/28/2011 04:14 PM, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@...hat.com>
> > Since symbol__alloc_hists need it, to avoid passing it around in many
> > functions have it in the symbol_conf struct.
> 
> I get why you want to do this, but symbol_conf seems to be an odd
> choice. This is number of events, not how to resolve or display symbols.

Well, its related to something you do per-symbol, namely annotate how
many hits per ip per event it got in its addr range.

I plan at some point look again at the symbol system to check things
like this, the filter, the need to have a map to load things, but for
now I think we can leave it there.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/