linux-kernel - Re: [PATCH] watchdog: add nowayout helpers to Watchdog Timer Driver Kernel API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Nov 2011 13:08:07 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Marc Vertes <marc.vertes@...fox.com>, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org,
	Dimitry Andric <dimitry.andric@...tom.com>,
	Ben Dooks <ben@...tec.co.uk>
Subject: Re: [PATCH] watchdog: add nowayout helpers to Watchdog Timer
	Driver Kernel API

Hi Wolfram,

> > diff --git a/Documentation/watchdog/00-INDEX b/Documentation/watchdog/00-INDEX
> > index fc51128..fc9082a 100644
> > --- a/Documentation/watchdog/00-INDEX
> > +++ b/Documentation/watchdog/00-INDEX
> > @@ -1,5 +1,7 @@
> >  00-INDEX
> >  	- this file.
> > +convert_drivers_to_kernel_api.txt
> > +	- how-to for converting old watchdog drivers to the new kernel API.
> 
> Since the howto needs a NOWAYOUT-update as well, I suggest I'll send a
> patch for that and take care of the missing index-entry there?

Ok.

> > @@ -142,6 +142,14 @@ bit-operations. The status bits that are defined are:
> >  * WDOG_NO_WAY_OUT: this bit stores the nowayout setting for the watchdog.
> >    If this bit is set then the watchdog timer will not be able to stop.
> >  
> > +To set the WDOG_NO_WAY_OUT status bit (before registering your watchdog
> > +timer device) you can either:
> > +* set it statically in your watchdog_device struct with
> > +	.status = WATCHDOG_NOWAYOUT_INIT_STATUS,
> > +  (this will set the value the same as CONFIG_WATCHDOG_NOWAYOUT) or
> > +* use the following helper function:
> > +static inline void watchdog_set_nowayout(struct watchdog_device *wdd, int nowayout)
> > +
> 
> I think one level of indentation would be helpful here so it visually
> belongs to the WDOG_NO_WAY_OUT paragraph?

Will fix that.

> > +/* Use the following function to set the nowayout feature */
> > +static inline void watchdog_set_nowayout(struct watchdog_device *wdd, int nowayout)
> > +{
> > +	if (nowayout)
> > +		set_bit(WDOG_NO_WAY_OUT, &wdd->status);
> > +}
> > +
> 
> Other than that:
> 
> Reviewed-by: Wolfram Sang <w.sang@...gutronix.de>
> 
> So, shall I fix the s3c-driver based on that or will you do?

Will included the fix in the final patch.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/