linux-kernel - Re: [PATCH v4] sound/soc/codecs: add LAPIS Semiconductor ML26124

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111129125029.GN2851@opensource.wolfsonmicro.com>
Date:	Tue, 29 Nov 2011 12:50:29 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Mike Frysinger <vapier@...too.org>,
	Daniel Mack <zonque@...il.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH v4] sound/soc/codecs: add LAPIS Semiconductor ML26124

On Tue, Nov 29, 2011 at 09:28:56PM +0900, Tomoya MORINAGA wrote:
> ML26124-01HB/ML26124-02GD is 16bit monaural audio CODEC which has high
> resistance to voltage noise. On chip regulator realizes power supply rejection
> ratio be over 90dB so more than 50dB is improved than ever. ML26124-01HB/

Given the questions you just asked myself and Lars-Peter it seems fairly
clear that the review comments from the previous version so I'm not
going to review this, please resend once the review comments have been
addressed.  Lars-Peter concern seemed especially serious, I'd expect
large sections of the audio functionality to not work without being
connected to the DAPM map.

In general if resubmitting code that has outstanding review issues you
should highlight the known issues and explain why you are resending;
usually if there's an active discussion in progress it's better to wait
for that to die down.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/