linux-kernel - Re: [PATCH] deadlock with suspend and quotas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111129130913.GE5635@quack.suse.cz>
Date:	Tue, 29 Nov 2011 14:09:13 +0100
From:	Jan Kara <jack@...e.cz>
To:	Mikulas Patocka <mpatocka@...hat.com>
Cc:	Jan Kara <jack@...e.cz>, Valerie Aurora <val@...consulting.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	dm-devel@...hat.com,
	Christopher Chaltain <christopher.chaltain@...onical.com>,
	esandeen@...hat.com, Surbhi Palande <csurbhi@...il.com>
Subject: Re: [PATCH] deadlock with suspend and quotas

On Tue 29-11-11 07:54:28, Mikulas Patocka wrote:
> > > This is technically impossible to achieve on ext2, fat or other 
> > > non-transactional filesystems. These filesystems have no locks around code 
> > > paths that set data or inodes dirty. And you still need working sync for 
> > > ext2. So the best thing to do in sync is to wait until the filesystem is 
> > > unfrozen.
> >   Then suspend is effectively unsupported on the filesystem and should
> > return EOPNOTSUPP? At least that's what I'd expect...
> 
> LVM uses suspend every time it changes layout of the logical volume. For 
> example when it converts to/from mirrored format, extends/shrinks the 
> volume, moves the volume to a different disk, takes a snapshots, merges a 
> snapshot back, on mirror or multipath failover.
> 
> For most of these actions (except taking a snapshot) it is irrelevant if 
> there are dirty data in the filesystem cache or not while it is suspended. 
  Hmm, then why do these operations suspend the filesystem if they
apparently don't need it? Sorry for my ignorance, I never seriously worked
with LVM code...

									Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/