linux-kernel - nfs no inotify IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 29 Nov 2011 13:13:50 -0800
From:	Maxim Uvarov <maxim.uvarov@...cle.com>
To:	linux-nfs@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, rlove@...ve.org,
	eparis@...isplace.org, john@...nmccutchan.com,
	viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org
Subject: nfs no inotify IN_DELETE  event

Hello,

I'm looking on inotify02 test future in mainline kernel on nfs:

inotify_init()                          = 3
inotify_add_watch(3, ".", IN_ALL_EVENTS)
creat("test_file1", 0755)               = 5
rename("test_file1", "test_file2")      = 0
getcwd("/mnt/nfs2/tmp", 256)            = 14
rename("/mnt/nfs2/tmp", "/mnt/nfs2/tmp.rename1") = 0
unlink("test_file2")                    = 0

After unlink() if file sytem is not nfs there is event:
IN_DELETE               0x00000200      /* Subfile was deleted */
for file test_file2. If file system is nfs there is no such event.

For the first time I thought that this is nfs sever bug related to nfs 
"silly renamed files" feature. But logically - file test_file2 was not 
deleted. It was removed with his directory from event watch directory to
non event watch directory.

1. is it ok that unlink() in that test returns 0, not -1 ENOENT?

2. should we get IN_DELETE for all files and sub folders for event watch 
directory? Or there should be only one event that directory was removed?

To reproduce:
http://ltp.sourceforge.net/
make
cd testcases/kernel/syscalls/inotify
export TMPDIR=/mnt/nfs/tmp/
export TDIRECTORY=/mnt/nfs/tmp/
./inotify02

Best regards,
Maxim Uvarov.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/