linux-kernel - Re: [PATCH] pm/next: Fix Build pm by ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201111300003.20488.rjw@sisk.pl>
Date:	Wed, 30 Nov 2011 00:03:20 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
Cc:	linux-kernel@...r.kernel.org,
	Linux PM list <linux-pm@...r.kernel.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>
Subject: Re: [PATCH] pm/next: Fix Build pm by ERR_PTR

On Tuesday, November 29, 2011, Nobuhiro Iwamatsu wrote:
> ERR_PTR needs linux/err.h.
> This add linux/err.h to linux/pm_domain.h.
> 
> -----
> In file included from drivers/sh/pm_runtime.c:15:
> include/linux/pm_domain.h: In function 'dev_to_genpd':
> include/linux/pm_domain.h:145: error: implicit declaration of function 'ERR_PTR'
> include/linux/pm_domain.h:145: warning: return makes pointer from integer without a cast
> In file included from include/linux/sh_clk.h:10,
> from drivers/sh/pm_runtime.c:19:
> include/linux/err.h: At top level:
> include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
> include/linux/pm_domain.h:145: note: previous implicit declaration of 'ERR_PTR' was here
> make[2]: *** [drivers/sh/pm_runtime.o] Error 1
> make[1]: *** [drivers/sh] Error 2
> -----
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>

I've just added an analogous patch from Guennadi to linux-pm/linux-next.

Thanks,
Rafael


> ---
>  include/linux/pm_domain.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index cc1a245..919bee1 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -9,6 +9,7 @@
>  #ifndef _LINUX_PM_DOMAIN_H
>  #define _LINUX_PM_DOMAIN_H
>  
> +#include <linux/err.h>
>  #include <linux/device.h>
>  
>  enum gpd_status {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/