linux-kernel - Re: [PATCH 1/2] thp: Add compound tail page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111129001927.GO24062@one.firstfloor.org>
Date:	Tue, 29 Nov 2011 01:19:27 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Youquan Song <youquan.song@...el.com>,
	linux-kernel@...r.kernel.org, aarcange@...hat.com,
	wli@...omorphy.com, david.woodhouse@...el.com,
	allen.m.kay@...el.com, mtosatti@...hat.com, chrisw@...hat.com,
	andi@...stfloor.org, chaohong.guo@...el.com,
	Youquan Song <youquan.song@...ux.intel.com>
Subject: Re: [PATCH 1/2] thp: Add compound tail page _mapcount when mapped

> > +++ b/arch/x86/mm/gup.c
> > @@ -201,6 +201,8 @@ static noinline int gup_huge_pud(pud_t pud, unsigned long addr,
> >  	do {
> >  		VM_BUG_ON(compound_head(page) != head);
> >  		pages[*nr] = page;
> > +		if (PageTail(page))
> > +			get_huge_page_tail(page);
> >  		(*nr)++;
> >  		page++;
> >  		refs++;
> 
> Is the patch also applicable to 3.1.x?

I suspect it's broken since many kernels back, at least since THP 
was introduced, maybe earlier.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/