linux-kernel - Re: [PATCH-RFC 1/2] tile: don't panic on iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111130071321.GB17781@redhat.com>
Date:	Wed, 30 Nov 2011 09:13:21 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Chris Metcalf <cmetcalf@...era.com>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Paul Mundt <lethal@...ux-sh.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-arch@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH-RFC 1/2] tile: don't panic on iomap

On Tue, Nov 29, 2011 at 10:05:11PM +0000, Arnd Bergmann wrote:
> On Tuesday 29 November 2011, Michael S. Tsirkin wrote:
> > diff --git a/arch/tile/include/asm/io.h b/arch/tile/include/asm/io.h
> > index c9ea165..be6090d 100644
> > --- a/arch/tile/include/asm/io.h
> > +++ b/arch/tile/include/asm/io.h
> > @@ -204,7 +204,8 @@ static inline long ioport_panic(void)
> >  
> >  static inline void __iomem *ioport_map(unsigned long port, unsigned int len)
> >  {
> > -       return (void __iomem *) ioport_panic();
> > +       pr_info("Trying to map an IO resource - it does not exit on tile.\n");
> > +       return NULL;
> >  }
> 
> Why not just set CONFIG_NO_IOPORT and make this unavailable at compile time?
> 
> 	Arnd

Well I think CONFIG_NO_IOPORT only has effect if you pull in asm-generic/io.h.
This might work but I have no idea. Presumably whoever wrote that architecture
considered and discarded setting GENERIC_IOMAP.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/