linux-kernel - Re: [PATCH 16/28] namespace: checkpatch wanking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1322642051.2123.11.camel@Joe-Laptop>
Date:	Wed, 30 Nov 2011 00:34:11 -0800
From:	Joe Perches <joe@...ches.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/28] namespace: checkpatch wanking

On Wed, 2011-11-30 at 06:50 +0000, Al Viro wrote:
> -	if (!(page = __get_free_page(GFP_KERNEL)))
> +	page = __get_free_page(GFP_KERNEL);
> +	if (!page)
>  		return -ENOMEM;
> Not sure...  In general I'd agree, but in this case...

Shrug.  I'm not sure there's much of a case other than
line count for keeping this a one-liner.

If you want these sorts of changes to be redone after
vfsmount-guts gets promoted, let me know.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/