[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4ED6331E.6020005@hartkopp.net>
Date: Wed, 30 Nov 2011 14:43:58 +0100
From: Oliver Hartkopp <socketcan@...tkopp.net>
To: Marc Kleine-Budde <mkl@...gutronix.de>
CC: Joe Perches <joe@...ches.com>,
Urs Thuermann <urs.thuermann@...kswagen.de>,
"David S. Miller" <davem@...emloft.net>, linux-can@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: Update logging style
On 29.11.2011 21:06, Marc Kleine-Budde wrote:
> On 11/29/2011 07:54 PM, Joe Perches wrote:
>> Use pr_fmt, pr_<level> and pr_<level>_ratelimited.
>> Coalesce format strings.
>>
>> Signed-off-by: Joe Perches <joe@...ches.com>
>
> The banners will probably looking a bit different, but I think nobody is
> screen scraping that output :)
>
> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>
Nobody but me. Therefore it get's a NACK.
Indeed the banners are pretty broken now ...
Before:
can: controller area network core (rev 20090105 abi 8)
NET: Registered protocol family 29
can: raw protocol (rev 20090105)
can: netlink gateway (rev 20101209)
can: broadcast manager protocol (rev 20090105 t)
After Joe's patch:
can: controller area network core (rev 20090105 abi 8)
NET: Registered protocol family 29
can_raw: raw protocol (rev 20090105)
can_gw: netlink gateway (rev 20101209)
can_bcm: broadcast manager protocol (rev 20090105 t)
IMO if you want to use pr_fmt() it should at least look like this:
can: controller area network core (rev 20090105 abi 8)
NET: Registered protocol family 29
can_raw: can raw protocol (rev 20090105)
can_gw: can netlink gateway (rev 20101209)
can_bcm: can broadcast manager protocol (rev 20090105 t)
I'm fine with using pr_fmt() for error/warning output but not for the banner
in the currently suggested way.
Regards,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists