linux-kernel - Re: [patch -next] ipc/mqueue: lock() => unlock() typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111130163607.GA32365@hallyn.com>
Date:	Wed, 30 Nov 2011 16:36:07 +0000
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Doug Ledford <dledford@...hat.com>,
	Jiri Slaby <jslaby@...e.cz>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Davidlohr Bueso <dave@....org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch -next] ipc/mqueue: lock() => unlock() typo

Quoting Dan Carpenter (dan.carpenter@...cle.com):
> There was a double lock typo introduced in b085f4bd6b21 "user namespace:
> make signal.c respect user namespaces"
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Jinkeys!

Acked-by: Serge Hallyn <serge@...lyn.com>

thanks very much, Dan.
-serge

> ---
> I think this patch is only needed in the -mm tree.
> 
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 691cfee..c246c83 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -558,7 +558,7 @@ static void __do_notify(struct mqueue_inode_info *info)
>  						ns_of_pid(info->notify_owner));
>  			sig_i.si_uid = user_ns_map_uid(info->user->user_ns,
>  						current_cred(), current_uid());
> -			rcu_read_lock();
> +			rcu_read_unlock();
>  
>  			kill_pid_info(info->notify.sigev_signo,
>  				      &sig_i, info->notify_owner);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/