linux-kernel - Re: [PATCH 02/16] MPILIB: Add a missing ENOMEM check [ver #2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21008.1322672401@redhat.com>
Date:	Wed, 30 Nov 2011 17:00:01 +0000
From:	David Howells <dhowells@...hat.com>
To:	Serge Hallyn <serge.hallyn@...onical.com>
Cc:	dhowells@...hat.com, keyrings@...ux-nfs.org,
	linux-crypto@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, dmitry.kasatkin@...el.com,
	zohar@...ux.vnet.ibm.com, arjan.van.de.ven@...el.com,
	alan.cox@...el.com
Subject: Re: [PATCH 02/16] MPILIB: Add a missing ENOMEM check [ver #2]

Serge Hallyn <serge.hallyn@...onical.com> wrote:

> >   	p = buffer = kmalloc(n, GFP_KERNEL);
> > +	if (p<  0)
> > +		return NULL;
> 
> Sorry, maybe i'm having a confused morning, but shouldn't this check be for
> p==NULL rather than p<0?

Bah.  You are, of course, right.  Updated for the next version.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/