linux-kernel - RE: [PATCH] watchdog: fix initialisation printout in s3c2410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 01 Dec 2011 16:29:46 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Thomas Abraham' <thomas.abraham@...aro.org>,
	'Dmitry Artamonow' <mad_soft@...ox.ru>
Cc:	'Wim Van Sebroeck' <wim@...ana.be>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	'Ben Dooks' <ben-linux@...ff.org>,
	linux-watchdog@...r.kernel.org
Subject: RE: [PATCH] watchdog: fix initialisation printout in s3c2410_wdt

Thomas Abraham wrote:
> 
> On 16 November 2011 14:16, Dmitry Artamonow <mad_soft@...ox.ru> wrote:
> > Looks like a typo creeped in, and driver prints
> > s3c2410-wdt s3c2410-wdt: watchdog active, reset abled, irq abled
> >
> > instead of
> > s3c2410-wdt s3c2410-wdt: watchdog active, reset enabled, irq enabled
> >
> > Also it may completely disinform about irq status, as it prints
> > "irq enabled" when S3C2410_WTCON_INTEN is in fact 0.
> >
> > Fix it.
> >
> > Signed-off-by: Dmitry Artamonow <mad_soft@...ox.ru>
> > ---
> >
> > It seems to be here for a long time, but I don't think it's
> > important enough for cc-ing stable.
> >
> > Also I haven't tested it, as I don't have a hardware, but it's
> > rather trivial (and yes, I checked with datasheet that 1 in
> > S3C2410_WTCON_*EN bits really means 'enabled')
> >
> 
> Tested on Exynos4210 based Origen board. This patch fixed in incorrect
> "irq enabled" message at bootup. Thanks for this fix.
> 
> Tested-by: Thomas Abraham <thomas.abraham@...aro.org>
> 

Acked-by: Kukjin Kim <kgene.kim@...sung.com>

Hi Wim,
Please pick this up in your tree and if any problem, let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


> >  drivers/watchdog/s3c2410_wdt.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/watchdog/s3c2410_wdt.c
> b/drivers/watchdog/s3c2410_wdt.c
> > index 5de7e4f..a79e384 100644
> > --- a/drivers/watchdog/s3c2410_wdt.c
> > +++ b/drivers/watchdog/s3c2410_wdt.c
> > @@ -401,8 +401,8 @@ static int __devinit s3c2410wdt_probe(struct
> platform_device *pdev)
> >
> >        dev_info(dev, "watchdog %sactive, reset %sabled, irq %sabled\n",
> >                 (wtcon & S3C2410_WTCON_ENABLE) ?  "" : "in",
> > -                (wtcon & S3C2410_WTCON_RSTEN) ? "" : "dis",
> > -                (wtcon & S3C2410_WTCON_INTEN) ? "" : "en");
> > +                (wtcon & S3C2410_WTCON_RSTEN) ? "en" : "dis",
> > +                (wtcon & S3C2410_WTCON_INTEN) ? "en" : "dis");
> >
> >        return 0;
> >
> > --
> > 1.7.5.1.300.gc565c

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/