linux-kernel - Re: [RGC PATCH 0/2] split file2alias using elf sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k46itcvg.fsf@rustcorp.com.au>
Date:	Wed, 30 Nov 2011 15:39:39 +1030
From:	Rusty Russell <rusty@...abs.org>
To:	Greg KH <greg@...ah.com>, Alessandro Rubini <rubini@...dd.com>
Cc:	linux-kernel@...r.kernel.org, siglesia@...n.ch,
	manohar.vanga@...n.ch
Subject: Re: [RGC PATCH 0/2] split file2alias using elf sections

On Tue, 22 Nov 2011 11:23:00 -0800, Greg KH <greg@...ah.com> wrote:
> On Fri, Nov 04, 2011 at 01:23:00PM +0100, Alessandro Rubini wrote:
> > When adding a new bus type with autoloading of modules, people should
> > always change the global scripts/mod/file2alias.c source file, whereas
> > most of the new code is just new files and individual Makefile/Kconfig
> > lines.
> > 
> > The first patch turns all the "normal" alias generation in a
> > table-driven loop. The second patch moves a few alias types out of the
> > main file2alias.c source, as a demonstration that the thing works.
> > 
> > I didn't move all bus/alias types out of the main file, as it's a huge
> > work. But if the approach is going to be accepted I can do that (or
> > happily leave the task to who volunteers).
> 
> Yes!!!!
> 
> I've been wanting this for years, and so have others (Linus, Andrew,
> etc.)
> 
> I'll gladly take this through my driver-core tree, as it can handle
> cross-bus issues like this.
> 
> Do you feel this series is good enough to accept, or do you want to
> respin it again?

The table driven loop is nice and simple, though the E() macro is a bit
contrived.

The separation into separate files just to avoid merge issues is
overkill and useless churn.  The conflicts are simple, and you've just
moved themto conflicts in the Makefile.

We'd be better off putting the table in alphabetical order and stopping
there.  Easy code, no tricks.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/