linux-kernel - Re: [PATCH v3] sound/soc/codecs: add LAPIS Semiconductor ML26124

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANKRQniRonz5UcQ-KgnFJptPkqgWWrJsFuW31f8bWCf_xx-tTA@mail.gmail.com>
Date:	Thu, 1 Dec 2011 16:57:52 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Mike Frysinger <vapier@...too.org>,
	Daniel Mack <zonque@...il.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH v3] sound/soc/codecs: add LAPIS Semiconductor ML26124

2011/12/1 Takashi Iwai <tiwai@...e.de>:
> You need to have read Mark's comment carefully.  He quoted another
> line before that.
>
> ================================================================
>> +     SOC_SINGLE_TLV("EQ Band1 Input Volume", ML26124_EQ_GAIN_BRAND1, 0,
>> +                     0xff, 1, eq_band_gain),
>
>> +     SOC_SINGLE("EQ BAND1 Switch", ML26124_FILTER_EN, 3, 1, 0),
>
> These should mathc.
> ================================================================
>
> So, you have two inconsistent names for EQ band1.
>

You mean "EQ Band1" and "EQ BAND1" are inconsistent names ?
If yes, can you accept the followings ?

EQ Band1 Input Volume
EQ Band1 Switch

Thanks,

------
tomoya
ROHM Co., Ltd.