linux-kernel - Re: [PATCH 18/25] dynamic_debug: Introduce global fake module param module.ddebug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfuBxzg-Bn8TD-h_kjo=hu4oCpkOLWvuC2NybpqQH5msokk4A@mail.gmail.com>
Date:	Thu, 1 Dec 2011 01:15:22 -0700
From:	Jim Cromie <jim.cromie@...il.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	jbaron@...hat.com, greg@...ah.com, joe@...ches.com,
	bart.vanassche@...il.com, linux-kernel@...r.kernel.org,
	Thomas Renninger <trenn@...e.de>
Subject: Re: [PATCH 18/25] dynamic_debug: Introduce global fake module param module.ddebug

>
> I think you're missing a neat trick here: we should be able to handle
> ddebug in the handle_unknown parameter to parse_args().
>
> Or am I missing something?
>

Jason suggested that too, offlist.
I pretty much agreed, but wanted to get the 1st 17 sent.

What gave me pause was this:
		pr_debug("Unknown argument: calling %p\n", handle_unknown);

it made me think about a common handler to deal with it 1st,
before the /* Find parameter */ loop, so that modules couldnt hijack
the dyndbg param, defeating the common handler.
OTOH, the BUILD_BUG_DECL prevents that hijack.

Maybe the best answer is silence the print when param is properly handled.

	if (handle_unknown) {
                int rc = handle_unknown(param, val);
		if (rc)
                      pr_debug("Unknown argument: calling %p\n",
handle_unknown);
		return rc;
       }

I'll do this shortly, see how it works out..
thanks

> Thanks,
> Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/