linux-kernel - Re: [PATCH 1/4] mfd: aat2870-core: Use gpio_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ED73CFA.7050308@nvidia.com>
Date:	Thu, 1 Dec 2011 17:38:18 +0900
From:	Jinyoung Park <jinyoungp@...dia.com>
To:	Axel Lin <axel.lin@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 1/4] mfd: aat2870-core: Use gpio_request_one

Acked-by: Jin Park <jinyoungp@...dia.com>

On 2011-12-01 오전 10:47, Axel Lin wrote:
> Use gpio_request_one() instead of multiple gpiolib calls.
>
> Signed-off-by: Axel Lin<axel.lin@...il.com>
> ---
>   drivers/mfd/aat2870-core.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
> index 02c4201..7620617 100644
> --- a/drivers/mfd/aat2870-core.c
> +++ b/drivers/mfd/aat2870-core.c
> @@ -407,13 +407,13 @@ static int aat2870_i2c_probe(struct i2c_client *client,
>   		aat2870->init(aat2870);
>
>   	if (aat2870->en_pin>= 0) {
> -		ret = gpio_request(aat2870->en_pin, "aat2870-en");
> +		ret = gpio_request_one(aat2870->en_pin, GPIOF_OUT_INIT_HIGH,
> +				       "aat2870-en");
>   		if (ret<  0) {
>   			dev_err(&client->dev,
>   				"Failed to request GPIO %d\n", aat2870->en_pin);
>   			goto out_kfree;
>   		}
> -		gpio_direction_output(aat2870->en_pin, 1);
>   	}
>
>   	aat2870_enable(aat2870);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/