linux-kernel - Re: [PATCH 1/2] virtio-scsi: first version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322729712.3702.8.camel@lappy>
Date:	Thu, 01 Dec 2011 10:55:12 +0200
From:	Sasha Levin <levinsasha928@...il.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	"Michael S. Tsirkin" <mst@...hat.com>,
	linux-scsi <linux-scsi@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Stefan Hajnoczi <stefanha@...ux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] virtio-scsi: first version

On Thu, 2011-12-01 at 09:36 +0100, Paolo Bonzini wrote:
> On 12/01/2011 07:33 AM, Sasha Levin wrote:
> > On Wed, 2011-11-30 at 14:54 +0100, Paolo Bonzini wrote:
> >> The virtio-scsi HBA is the basis of an alternative storage stack
> >> for QEMU-based virtual machines (including KVM).  Compared to
> >> virtio-blk it is more scalable, because it supports many LUNs
> >> on a single PCI slot), more powerful (it more easily supports
> >> passthrough of host devices to the guest) and more easily
> >> extensible (new SCSI features implemented by QEMU should not
> >> require updating the driver in the guest).
> >>
> >> Signed-off-by: Paolo Bonzini<pbonzini@...hat.com>
> >> ---
> >>   drivers/scsi/Kconfig       |    8 +
> >>   drivers/scsi/Makefile      |    1 +
> >>   drivers/scsi/virtio_scsi.c |  478 ++++++++++++++++++++++++++++++++++++++++++++
> >>   include/linux/virtio_ids.h |    1 +
> >    include/linux/virtio_scsi.h is missing here.

I was actually hoping you could send the .h so I could do some hacking
on it :)

> > Maybe default to one if not specified (=0), like in virtio-blk.
> 
> Good idea.  Though with sg_elems=1 it is insanely slow.

It's either that or fail on sg_elems=0, since currently if it's 0 it
looks like the failure will be non-obvious.

> > Shouldn't these kmemcaches be per-device and not globally shared between
> > all devices?
> 
> In practice it will be rare (and it's part of the design) to have more 
> than one virtio-scsi device (perhaps two: one for passthrough and one 
> for other block devices).  If the kmemcaches are a bottleneck, what you 
> want is making them per-virtqueue.  Fixing it is simple if it turns out 
> to be a problem, and it is simpler if I do it together with multi-vq 
> support.

I guess we should just remember test that when multi-vq support is
added.

-- 

Sasha.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/